Skip to content

perf(search): remove root ranking diagnostics#481

Closed
JustYannicc wants to merge 1 commit into
SuperCmdLabs:mainfrom
JustYannicc:codex/perf-remove-root-debug-ipc
Closed

perf(search): remove root ranking diagnostics#481
JustYannicc wants to merge 1 commit into
SuperCmdLabs:mainfrom
JustYannicc:codex/perf-remove-root-debug-ipc

Conversation

@JustYannicc

Copy link
Copy Markdown
Collaborator

What changed

  • Removed the temporary SC-RANK2 diagnostic effect from the root search command model.
  • Removed the root search ranking startup/liveness console.info stamp.

Why

  • The diagnostic effect ran as the root search query/ranked candidates changed, scanning candidates and sending window.electron.whisperDebugLog IPC from the per-keystroke ranking path.
  • The startup stamp was only for verifying an earlier ranking fix and should not run in production startup paths.

Before evidence:

  • node scripts/test-root-search-ranking.mjs: passed after hydrating dependencies; emitted the startup liveness log.
  • Debug-path measurement: {"phase":"before","scRank2Tags":3,"rootSearchWhisperDebugLogCallsites":2,"tempDiagnosticEffects":1,"startupLivenessLogs":1}.

After evidence:

  • Debug-path measurement: {"phase":"after","scRank2Tags":0,"rootSearchWhisperDebugLogCallsites":0,"tempDiagnosticEffects":0,"startupLivenessLogs":0}.

Compatibility impact

  • Ranking scores, result ordering, section assembly, and user-facing behavior are unchanged.
  • No user-facing strings were added, renamed, or removed, so no locale files changed.
  • Debug-only SC-RANK2 IPC/log output is no longer available from the root search hot path.

How tested

  • node scripts/test-root-search-ranking.mjs before the fix: pass.
  • node scripts/test-root-search-ranking.mjs after the fix: pass.
  • Codex LSP diagnostics:
    • src/renderer/src/utils/root-search-ranking.ts: no diagnostics.
    • src/renderer/src/hooks/useLauncherCommandModel.ts: reports existing BrowserSearchSource typing diagnostics around profile browser IDs outside this diff.
  • pnpm exec tsc -p tsconfig.renderer.json --noEmit --pretty false: fails on existing repo-wide TypeScript diagnostics, including the hook profile typing diagnostics above plus unrelated files such as App.tsx, CameraExtension.tsx, LiquidGlassSurface.tsx, and Raycast runtime modules.

@JustYannicc JustYannicc changed the title [codex] Remove root search ranking diagnostics perf(search): remove root ranking diagnostics Jul 3, 2026
@JustYannicc

Copy link
Copy Markdown
Collaborator Author

Superseded by the consolidated upstream PR #535: #535

@JustYannicc JustYannicc closed this Jul 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant