perf(search): remove root ranking diagnostics#481
Closed
JustYannicc wants to merge 1 commit into
Closed
Conversation
Collaborator
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
SC-RANK2diagnostic effect from the root search command model.console.infostamp.Why
window.electron.whisperDebugLogIPC from the per-keystroke ranking path.Before evidence:
node scripts/test-root-search-ranking.mjs: passed after hydrating dependencies; emitted the startup liveness log.{"phase":"before","scRank2Tags":3,"rootSearchWhisperDebugLogCallsites":2,"tempDiagnosticEffects":1,"startupLivenessLogs":1}.After evidence:
{"phase":"after","scRank2Tags":0,"rootSearchWhisperDebugLogCallsites":0,"tempDiagnosticEffects":0,"startupLivenessLogs":0}.Compatibility impact
SC-RANK2IPC/log output is no longer available from the root search hot path.How tested
node scripts/test-root-search-ranking.mjsbefore the fix: pass.node scripts/test-root-search-ranking.mjsafter the fix: pass.src/renderer/src/utils/root-search-ranking.ts: no diagnostics.src/renderer/src/hooks/useLauncherCommandModel.ts: reports existingBrowserSearchSourcetyping diagnostics around profile browser IDs outside this diff.pnpm exec tsc -p tsconfig.renderer.json --noEmit --pretty false: fails on existing repo-wide TypeScript diagnostics, including the hook profile typing diagnostics above plus unrelated files such asApp.tsx,CameraExtension.tsx,LiquidGlassSurface.tsx, and Raycast runtime modules.